Discussion: allow `,` at the end of `With` clause

Question

Discussion: allow `,` at the end of `With` clause

dev=> create table t1 (v1 int, v2 int);
CREATE_TABLE
dev=> create table t2 (v1 int, v2 int,);
CREATE_TABLE

dev=> create source s1 (v1 int, v2 int,) with ( connector = 'datagen') ROW FORMAT JSON;
CREATE_SOURCE
dev=> create source s1 (v1 int, v2 int,) with ( connector = 'datagen',) ROW FORMAT JSON;
ERROR:  QueryError: sql parser error: Expected identifier, found: )

Seems it does not hurt?

0 1 1

database serverless sql rust postgresql cloud-native stream-processing distributed-database

lmatz

2023-01-09

CAJan93 · Accepted Answer · 2023-01-24

This seems to be not in line with PSQL. Are we sure we want to support this syntax? Just tried this at onecompiler and received the following error for above syntax:

select version(); 
version                                                           
-----------------------------------------------------------------------------------------------------------------------------
 PostgreSQL 14.6 (Debian 14.6-1.pgdg110+1) on x86_64-pc-linux-gnu, compiled by gcc (Debian 10.2.1-6) 10.2.1 20210110, 64-bit
(1 row)


create table t2 (v1 int, v2 int,);
psql:commands.sql:2: ERROR:  syntax error at or near ")"
LINE 1: create table t2 (v1 int, v2 int,);