I sometimes have errors in my autogenerated prost files. Can we make it that check ignores these files? Does it makes sense that check ignores everything that is in .gitignore?
warning: unused import: `crate::plan_common::*`
--> src/prost/src/plan_common.serde.rs:2:5
|
2 | use crate::plan_common::*;
| ^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
It's interesting that generated files have lint errors. 🤔 I suggest adding a allow or expect attribute here if necessary.
https://github.com/risingwavelabs/risingwave/blob/831e94530e87cb0bc975ada37c40a0dc11ae85ca/src/prost/src/lib.rs#L15
@BugenZhao Yea, I was also surprised about that. Maybe it is because I am switching between branches and these branches use different protobuf messages 🤔 What I usually do is call cargo clean. It solves the issue, but I feel like we should not have this issue in the first place.
